[qatzip] Use boringssl alias for consistent fips#31898
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Jan 19, 2024
Merged
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
ggreenway
approved these changes
Jan 18, 2024
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
Member
|
backport for release/v1.29 added in #32211 @ravenblackx does this need to be backported further? |
Contributor
Author
|
I don't think so, it was just a release problem with 1.29 |
phlax
pushed a commit
that referenced
this pull request
Feb 6, 2024
Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
This was referenced Apr 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: [qatzip] Use boringssl alias for consistent fips
Additional Description: This addresses the most immediate issue of #31874. There remains another issue where it still fails to build, and it's still an issue in boringssl, but it's no longer caused by inconsistent boringssl versions, so this is a step in the right direction.
Risk Level: Near-zero.
Testing: Manually;
bazel build --define boringssl=fips //contrib/exe:envoy-staticfails later after the change.Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a