Fix the wrong server response match for pg upstream tls#31762
Fix the wrong server response match for pg upstream tls#31762ravenblackx merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Abdul Matin <admatinm@gmail.com>
|
@shiponcs @cpakulski shouldn't this change also need to fix and/or add unit tests?? I mean, seems this part should be revisited: https://github.com/envoyproxy/envoy/blob/main/contrib/postgres_proxy/filters/network/test/postgres_decoder_test.cc#L668 (or am I missing something?) |
|
@fabriziomello Thanks. I think you are right and we will have to edit here accordingly too: https://github.com/envoyproxy/envoy/blob/main/contrib/postgres_proxy/filters/network/test/postgres_integration_test.cc |
|
I am waiting to get approval from @cpakulski so as to make change in the test accordingly. |
cpakulski
left a comment
cpakulski
left a comment
There was a problem hiding this comment.
You also need to update following lines:
| upstreamSSL = true; | ||
| } else { | ||
| if (c != 'E') { | ||
| if (c != 'N') { |
There was a problem hiding this comment.
Looks good. I do not remember why we used 'E'.
Signed-off-by: Abdul Matin <admatinm@gmail.com>
Signed-off-by: Abdul Matin <admatinm@gmail.com>
Signed-off-by: Abdul Matin <admatinm@gmail.com>
Wow... almost at the same time... hehehehe |
4 participants
In this doc of PostgreSQL, section 55.2.10. outlines what is sent from server upon requesting for SSL-
Current postgres filter matches 'E' instead of 'N' what was fixed in this PR.
Commit Message:
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Fixes commit #23990