connection: Add TCP_FASTOPEN listener option (continuation)#3157
Merged
htuch merged 2 commits intoenvoyproxy:masterfrom Apr 25, 2018
Merged
connection: Add TCP_FASTOPEN listener option (continuation)#3157htuch merged 2 commits intoenvoyproxy:masterfrom
htuch merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Bjoern Metzdorf <bmetzdorf@apple.com>
Signed-off-by: Bjoern Metzdorf <bmetzdorf@apple.com>
Member
|
Looks good so far @bmetzdorf, will stay tuned for the remaining TODOs. |
Contributor
Author
|
@htuch @ggreenway Looks like #3042 will touch a bit of this too. I'd rather wait with the missing pieces here until that is done. Would it be worthwhile to get the current changes here merged though? |
htuch
approved these changes
Apr 25, 2018
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
Sure, let's merge this one meanwhile. Thanks.
Contributor
Author
|
thx! |
ramaraochavali
pushed a commit
to ramaraochavali/envoy
that referenced
this pull request
May 3, 2018
…xy#3157) Signed-off-by: Bjoern Metzdorf <bmetzdorf@apple.com> Signed-off-by: Rama <rama.rao@salesforce.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is addressing the last unaddressed comments from #2793
Done here:
#2793 (diff)
Rename socket_option_test_harness to socket_option_test
#2793 (diff)
Tested with
if 0on both Linux and macOS. All tests still pass.#2793 (diff)
Changed to EXPECT_THROW_WITH_MESSAGE
Still TODO:
missing test coverage
#2793 (diff)
setTcpSocketOption
#2793 (diff)
@htuch @ggreenway