ext_authz: fix body buffering feature on ExtAuthZ per-route filter#31437
Merged
ggreenway merged 5 commits intoenvoyproxy:mainfrom Jan 3, 2024
Merged
ext_authz: fix body buffering feature on ExtAuthZ per-route filter#31437ggreenway merged 5 commits intoenvoyproxy:mainfrom
ggreenway merged 5 commits intoenvoyproxy:mainfrom
Conversation
agrawroh
force-pushed
the
extauthz-fix
branch
3 times, most recently
from
e52b678 to
d19f38d
Compare
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
extauthz-fix
branch
from
d19f38d to
52c4edb
Compare
tyxia
approved these changes
Dec 22, 2023
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, Thank you for fixing this
Fixed the typo in L#2977 Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
agrawroh
force-pushed
the
extauthz-fix
branch
from
f248e95 to
9d7e050
Compare
tyxia
approved these changes
Dec 27, 2023
Member
tyxia
left a comment
tyxia
left a comment
There was a problem hiding this comment.
LGTM, Thanks!
Defer to @ggreenway for review and merge
adisuissa
reviewed
Jan 2, 2024
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Drive-by comment, please add a release note.
ggreenway
requested changes
Jan 2, 2024
Signed-off-by: Rohit Agrawal <rohit.agrawal@databricks.com>
Member
Author
Added, Thanks! |
ggreenway
approved these changes
Jan 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The with_request_body feature on per-route ExtAuthZ filter is not working as expected.
See: #31436
Changes
This PR fixes the body propagation when with_request_body is enabled on a per-route ExtAuthZ filter. Current implementation reads the flags for partial body and max bytes size only from the main HTTP filter and discards these configs on the per-route ExtAuthZ filter.
Commit Message: fix body buffering feature on ExtAuthZ per-route filter
Additional Description:add new private fields to hold the final state for the max bytes and whether partial body is allowed in the ExtAuthZ filter
Risk Level: Low
Testing: Added Tests
Docs Changes: N/A
Release Notes: Added
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]