Skip to content

bazel/deps: Shift edenhill/kakfa dep -> confluentinc#31393

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-edenhill-confluent
Dec 15, 2023
Merged

bazel/deps: Shift edenhill/kakfa dep -> confluentinc#31393
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-edenhill-confluent

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Dec 15, 2023

Also adds workaround for #31394

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Dec 15, 2023
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @htuch

🐱

Caused by: #31393 was opened by phlax.

see: more, trace.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the deps-edenhill-confluent branch from b693396 to 0dd7a8f Compare December 15, 2023 13:33
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Dec 15, 2023

pushing through to fix CI

@phlax phlax merged commit a9978b4 into envoyproxy:main Dec 15, 2023
@moderation
Copy link
Copy Markdown
Contributor

Do you want a follow up changing edenhill_librdkafka to confluentinc_librdkafka?

bazel/repositories.bzl
1414:        name = "edenhill_librdkafka",

bazel/repository_locations.bzl
1323:    edenhill_librdkafka = dict(

bazel/foreign_cc/BUILD
88:    lib_source = "@edenhill_librdkafka//:all",

tools/dependency/BUILD
34:    | del(.edenhill_librdkafka)

phlax added a commit to phlax/envoy that referenced this pull request Dec 15, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Dec 15, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit to phlax/envoy that referenced this pull request Dec 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Dec 18, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants