Skip to content

examples/grpc: fix go.mod#31299

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
mosn:fix-example-grpc
Dec 12, 2023
Merged

examples/grpc: fix go.mod#31299
phlax merged 1 commit intoenvoyproxy:mainfrom
mosn:fix-example-grpc

Conversation

@doujiang24
Copy link
Copy Markdown
Member

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: doujiang24 <doujiang24@gmail.com>
@doujiang24
Copy link
Copy Markdown
Member Author

Hello @phlax , this could fix #31294, hope it fix the error from dependabot-updater.
I haven't seen the error message from dependabot-updater, guess it complains an invalid go mod file.

@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 12, 2023

yeah - lets see - i tried something similar - not sure why but then i ended up adding a go.sum file also - which didnt work

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @doujiang24

@phlax phlax merged commit f78054a into envoyproxy:main Dec 12, 2023
@phlax
Copy link
Copy Markdown
Member

phlax commented Dec 12, 2023

@doujiang24 unfortunately this one didnt work - error is

  proxy | 2023/12/12 13:27:33 [405] GET https://proxy.golang.org:443/github.com/envoyproxy/envoy/@v/list
  proxy | 2023/12/12 13:27:33 [405] 200 https://proxy.golang.org:443/github.com/envoyproxy/envoy/@v/list
updater | 2023/12/12 13:27:33 INFO <job_761393423> Handled error whilst updating golang.org/x/net: dependency_file_not_resolvable {:message=>"github.com/envoyproxy/envoy/examples/grpc-bridge/server/kv: cannot find module providing package github.com/envoyproxy/envoy/examples/grpc-bridge/server/kv"}
updater | 2023/12/12 13:27:33 INFO <job_761393423> Finished job processing
updater | 2023/12/12 13:27:33 INFO Results:

https://github.com/envoyproxy/envoy/network/updates/761393423

@doujiang24
Copy link
Copy Markdown
Member Author

oh, I'll take a look tomorrow.
https://github.com/envoyproxy/envoy/network/updates/761393423 is 404 on my side, might be lack of permission.

@doujiang24 doujiang24 deleted the fix-example-grpc branch December 13, 2023 01:14
phlax pushed a commit to phlax/envoy that referenced this pull request Dec 14, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Dec 14, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit to phlax/envoy that referenced this pull request Dec 15, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax pushed a commit that referenced this pull request Dec 15, 2023
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
SeanKilleen pushed a commit to SeanKilleen/envoy that referenced this pull request Apr 3, 2024
Signed-off-by: doujiang24 <doujiang24@gmail.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants