CI: explicitly specify the service want to start for kafka and websocket example#31175
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Dec 5, 2023
Merged
CI: explicitly specify the service want to start for kafka and websocket example#31175phlax merged 1 commit intoenvoyproxy:mainfrom
phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
/assign @phlax |
soulxu
changed the title
soulxu
changed the title
phlax
reviewed
Dec 5, 2023
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
nice! lglm, thanks @soulxu
i wonder what changed - these used to work ~reliably i think
github has a pretty awful system for vm/agent versioning - basically they change things as they feel without much notice - this has broken docker/compose previously
phlax
approved these changes
Dec 5, 2023
delphisfang
pushed a commit
to delphisfang/envoy
that referenced
this pull request
Dec 10, 2023
…ket example (envoyproxy#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Dec 11, 2023
…ket example (envoyproxy#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Dec 12, 2023
…ket example (#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Dec 15, 2023
…ket example (envoyproxy#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Dec 15, 2023
…ket example (#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io>
SeanKilleen
pushed a commit
to SeanKilleen/envoy
that referenced
this pull request
Apr 3, 2024
…ket example (envoyproxy#31175) Signed-off-by: He Jie Xu <hejie.xu@intel.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: ci: explicitly specify the service want to start for kafka example
Additional Description:
CI failed on kafka and websocket example verify test:
Risk Level: low
Testing: CI test
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a