[bp/1.27] buffer: separate the BufferFragement release and drain tracker (#28770)#30788
Merged
phlax merged 2 commits intoenvoyproxy:release/v1.27from Nov 21, 2023
Merged
[bp/1.27] buffer: separate the BufferFragement release and drain tracker (#28770)#30788phlax merged 2 commits intoenvoyproxy:release/v1.27from
phlax merged 2 commits intoenvoyproxy:release/v1.27from
Conversation
…proxy#28770) Fixes envoyproxy#28760 Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
cc @phlax @ggreenway |
Member
|
DCO failed /wait |
Member
Author
|
@phlax do you know what happened to the DCO? it seems failed on many old commits |
Member
|
not sure why DCO is failing - the message is pretty obviously signed |
Signed-off-by: He Jie Xu <hejie.xu@intel.com>
Member
Author
|
@phlax would you like to take a look at this? thanks! |
phlax
approved these changes
Nov 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: [bp/1.27] buffer: separate the BufferFragement release and drain tracker (#28770)
Additional Description:
This the backport of #28770
There is a requirement for the user space io handle and iouring io handle to move the write buffer to its own buffer and invoke the drain trackers. But becomes an issue for the BufferFragment, the BufferFragement's releasor is invoked by the drain tracker also. After moving with invoke drain trackers, the memory in the BufferFragment will be released too, which leads to the Buffer reference some memory already released.
Risk Level: high
Testing: unittest
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #28760
Related to issue: #28395