Skip to content

deps: update the deprecation status of libcurl #30731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 3 commits into from
Nov 7, 2023
Merged

deps: update the deprecation status of libcurl #30731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
58e1a8c
deps: update the deprecation status of libcurl
Nov 5, 2023
ed77b02
add the timeline for deprecation
Nov 5, 2023
4ffaae3
existing
Nov 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion bazel/repositories.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,9 @@ def _io_opencensus_cpp():
)

def _com_github_curl():
# Used by OpenCensus Zipkin exporter.
# The usage by AWS extensions common utilities is deprecated and will be removed by Q3 2024 after
# the deprecation period of 2 releases. Please DO NOT USE curl dependency for any new or existing extensions.
# See https://github.com/envoyproxy/envoy/issues/11816 & https://github.com/envoyproxy/envoy/pull/30731.
external_http_archive(
name = "com_github_curl",
build_file_content = BUILD_ALL_CONTENT + """
Expand Down
4 changes: 2 additions & 2 deletions bazel/repository_locations.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1068,7 +1068,8 @@ REPOSITORY_LOCATIONS_SPEC = dict(
license = "Apache-2.0",
license_url = "https://github.com/census-instrumentation/opencensus-cpp/blob/{version}/LICENSE",
),
# This should be removed, see https://github.com/envoyproxy/envoy/issues/11816.
# Curl usage is under deprecation and will be removed by Q3 2024 before v1.31 release in July-2024.
# See https://github.com/envoyproxy/envoy/issues/11816 & https://github.com/envoyproxy/envoy/pull/30731.
com_github_curl = dict(
project_name = "curl",
project_desc = "Library for transferring data with URLs",
Expand All @@ -1082,7 +1083,6 @@ REPOSITORY_LOCATIONS_SPEC = dict(
"envoy.filters.http.aws_lambda",
"envoy.filters.http.aws_request_signing",
"envoy.grpc_credentials.aws_iam",
"envoy.tracers.opencensus",
],
release_date = "2023-10-11",
cpe = "cpe:2.3:a:haxx:libcurl:*",
Expand Down