access_logs: minor string fix and return code checking#3053
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Apr 11, 2018
Merged
access_logs: minor string fix and return code checking#3053mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Matt Rice <mattrice@google.com>
dnoe
approved these changes
Apr 11, 2018
mattklein123
approved these changes
Apr 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
The protobuf string types were missing from a few instantiations and a call to the message->json conversion method wasn't checking its return code.
Risk Level: Low
Testing: Unit tests already exist for these methods.