Separate envoy_py_namespace to avoid cascading dependencies#30334
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Oct 20, 2023
Merged
Separate envoy_py_namespace to avoid cascading dependencies#30334phlax merged 1 commit intoenvoyproxy:mainfrom
phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
ravenblackx
requested review from
RyanTheOptimist,
abeyad and
alyssawilk
as code owners
phlax
approved these changes
Oct 19, 2023
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @ravenblackx
/backport
repokitteh-read-only
bot
added
the
backport/review
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Oct 22, 2023
…xy#30334) Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Oct 22, 2023
…xy#30334) Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
to phlax/envoy
that referenced
this pull request
Oct 22, 2023
…xy#30334) Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
pushed a commit
that referenced
this pull request
Oct 22, 2023
Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io>
SeanKilleen
pushed a commit
to SeanKilleen/envoy
that referenced
this pull request
Apr 3, 2024
…xy#30334) Signed-off-by: Raven Black <ravenblack@dropbox.com> Signed-off-by: Ryan Northey <ryan@synca.io> Signed-off-by: Sean Killeen <SeanKilleen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Separate envoy_py_namespace to avoid cascading dependencies
Additional Description: Before this change, envoy_py_namespace cascading into a
bzl load()dependency on@base_pip3, which makes binary builds that don't actually have this dependency need to pull in a bunch more repos than they actually need.Risk Level: None, change is a no-op.
Testing: CI should tell us if anything build-related broke.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a