Prevent recursion during premature reset check#30270
Merged
yanavlasov merged 1 commit intoenvoyproxy:mainfrom Oct 18, 2023
Merged
Prevent recursion during premature reset check#30270yanavlasov merged 1 commit intoenvoyproxy:mainfrom
yanavlasov merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
RyanTheOptimist
approved these changes
Oct 17, 2023
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Wow, subtle! Thanks for getting to the bottom of this!
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Oct 18, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Oct 18, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Oct 18, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
yanavlasov
added a commit
to yanavlasov/envoy
that referenced
this pull request
Oct 18, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this pull request
Oct 23, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this pull request
Oct 23, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
phlax
pushed a commit
that referenced
this pull request
Oct 23, 2023
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check. Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Prevent doConnectionClose to be called recursively when connection with active requests is disconnected due to premature reset check.
Additional Description:
It was able to make the test crash with 17K outstanding requests. I think this is low severity bug, since it is unlikely that edge Envoys would set the limit on concurrent streams this high.
Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A