bazel/ci: Cleanup flags and env vars#30211
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Oct 16, 2023
Merged
Conversation
phlax
force-pushed
the
rbe-flags
branch
29 times, most recently
from
1c7d1e0 to
e027fa1
Compare
phlax
force-pushed
the
rbe-flags
branch
2 times, most recently
from
e95dc2f to
783f348
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
wbpcode
approved these changes
Oct 16, 2023
Member
wbpcode
left a comment
wbpcode
left a comment
There was a problem hiding this comment.
LGTM. Thanks. Basically, I think we have no any promise to the backward compatibility of CI script. So I personally think the deprecation is unnecesary.
Member
Author
my thought too - i was being defensive - ill cleanup |
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
to phlax/envoy
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
added a commit
that referenced
this pull request
Oct 16, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should simplify and improve sep of responsibility between parts of CI, and make it easier to document dev paths
In a follow up i will do something similar for the github ci which was designed to mimic azp, and can be simplified in a similar manner
This is a step - ive tried not to be too disruptive and added some deprecation on stuff that can be removed, to be sure noone else is using it.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]