Skip to content

Add release target to copy binary after build server_only#30204

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
keithmattix:ci/add-flag-to-reenable-old-build-path
Oct 18, 2023
Merged

Add release target to copy binary after build server_only#30204
phlax merged 2 commits intoenvoyproxy:mainfrom
keithmattix:ci/add-flag-to-reenable-old-build-path

Conversation

@keithmattix
Copy link
Copy Markdown
Contributor

Add a release target to opt into behavior before #29646 was merged, specifically the copying of the final binary to something akin to envoy_binary.tar.gz

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@repokitteh-read-only
Copy link
Copy Markdown

Hi @keithmattix, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #30204 was opened by keithmattix.

see: more, trace.

@phlax phlax self-assigned this Oct 16, 2023
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@keithmattix thanks for following up and working on this

the first thing im wondering about is the name

not sure what is best but i would probably err towards release.server_only.binary

the next thing is that im trying to remove the bazel_envoy_binary_build fun

i had a look at what this builds for comparison to our newer bazel code path

this is what this target builds:

$ find linux/amd64/
linux/amd64/
linux/amd64/build_envoy_release_stripped
linux/amd64/build_envoy_release_stripped/envoy
linux/amd64/build_envoy_release
linux/amd64/build_envoy_release/envoy.dwp
linux/amd64/build_envoy_release/schema_validator_tool
linux/amd64/build_envoy_release/su-exec
linux/amd64/build_envoy_release/envoy

whereas the newer path builds the following (in a tarball)

$ tar tf ~/Downloads/release.tar.zst 
dbg/
dbg/envoy
dbg/envoy-contrib
dbg/envoy-contrib.dwp
dbg/envoy.dwp
envoy
envoy-contrib
utils/
utils/su-exec

essentially the difference being that it does include contrib, and doesnt include the schema_validator_tool - not sure what is best for that possibly adding a separate ci target

im happy to land this for now (pending name update) but would like to iterate so that it uses the newer code path - i will update it to make contrib optional

at that point it will output a tarball - the current linux/xxx paths were used previously for the docker build and that is not the case any longer (not in this way anyhow) so im thinking this is probably not something envoy's ci should continue doing

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 16, 2023

pasting ci advice

  Please fix your editor to ensure:

      - no trailing whitespace
      - no preceding mixed tabs/spaces
      - all files end with a newline

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix
Copy link
Copy Markdown
Contributor Author

@phlax Thanks for the review! That plan SGTM

@phlax
Copy link
Copy Markdown
Member

phlax commented Oct 18, 2023

/retest

@phlax phlax merged commit 0371a28 into envoyproxy:main Oct 18, 2023
keithmattix added a commit to keithmattix/envoy that referenced this pull request Oct 18, 2023
…#30204)

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
keithmattix added a commit to keithmattix/envoy that referenced this pull request Oct 18, 2023
…#30204)

Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
phlax pushed a commit that referenced this pull request Oct 18, 2023
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
phlax pushed a commit that referenced this pull request Oct 18, 2023
Signed-off-by: Keith Mattix II <keithmattix@microsoft.com>
@keithmattix keithmattix deleted the ci/add-flag-to-reenable-old-build-path branch October 23, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants