[Backport 1.26] tracing: fix Datadog span name (#29932)#30182
Merged
phlax merged 1 commit intoenvoyproxy:release/v1.26from Oct 13, 2023
Merged
[Backport 1.26] tracing: fix Datadog span name (#29932)#30182phlax merged 1 commit intoenvoyproxy:release/v1.26from
phlax merged 1 commit intoenvoyproxy:release/v1.26from
Conversation
Backport c3646f9 to 1.26 Additional testing: Also, I ran the sources/extensions/tracers/datadog/demo both with and without these changes. Verified that the produced span's "operation name" before these changes is not as desired. Verified that the produced span's "operation name" after these changes is as desired. Desired: "Operation name" is "envoy.proxy", and "resource name" is the operation_name passed to startSpan. Risk Level: low Testing: See the modified unit test. Docs Changes: n/a Release Notes: updated Signed-off-by: David Goffredo <david.goffredo@datadoghq.com>
|
Hi @florianmutter, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Member
|
thanks for raising this @florianmutter would you be able to do similar for 1.24,1.25, and 1.27 (if affected) ? |
Member
|
cc @dgoffredo |
Author
I think only 1.27 is also affected. Will create a PR as well |
Author
|
Backport for 1.27 here: #30186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
tracing: fix Datadog span name
Backport c3646f9 to 1.26
Additional testing:
Also, I ran the sources/extensions/tracers/datadog/demo both with and without these changes. Verified that the produced span's "operation name" before these changes is not as desired. Verified that the produced span's "operation name" after these changes is as desired.
Desired: "Operation name" is "envoy.proxy", and "resource name" is the operation_name passed to startSpan.
Risk Level: low
Testing: See the modified unit test.
Docs Changes: n/a
Release Notes: updated