Skip to content

ci/rbe: Enable Engflow RBE for prechecks#30142

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-engflow-prechecks
Oct 13, 2023
Merged

ci/rbe: Enable Engflow RBE for prechecks#30142
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-engflow-prechecks

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Oct 12, 2023

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax marked this pull request as draft October 12, 2023 10:44
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 12, 2023

cc @krajshiva

@phlax phlax force-pushed the ci-engflow-prechecks branch from 70b2c9f to 76a20bd Compare October 12, 2023 10:50
@krajshiva
Copy link
Copy Markdown
Contributor

Thanks - should it be working for pull_request? pull_request_target and engflow RBE build seems to be working here.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 12, 2023

Thanks - should it be working for pull_request? pull_request_target and engflow RBE build seems to be working here.

it can only work with pull_request_target to use the engflow/github auth

@phlax phlax force-pushed the ci-engflow-prechecks branch from 9087a31 to d679be9 Compare October 13, 2023 07:07
@phlax phlax changed the title [WIP] ci/rbe: Enable Engflow RBE for prechecks ci/rbe: Enable Engflow RBE for prechecks Oct 13, 2023
@phlax phlax marked this pull request as ready for review October 13, 2023 08:35
@phlax phlax marked this pull request as draft October 13, 2023 08:35
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the ci-engflow-prechecks branch from d679be9 to b1740ab Compare October 13, 2023 08:48
@phlax phlax marked this pull request as ready for review October 13, 2023 08:52
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@phlax phlax merged commit 2be475e into envoyproxy:main Oct 13, 2023
phlax added a commit to phlax/envoy that referenced this pull request Oct 13, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Oct 13, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Oct 13, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants