UNCLEANTLY Revert " notifier: adding basic oncall notifications (#298…#30044
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Oct 9, 2023
Merged
UNCLEANTLY Revert " notifier: adding basic oncall notifications (#298…#30044alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
…yproxy#29820)" This reverts commit c495291. Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
jmarantz
approved these changes
Oct 9, 2023
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
blindly approving with no idea of context.
Member
|
as commented offline - i think this is not needed - i believe the ci issue should be fixed (i dont think it ran again yet) |
phlax
requested changes
Oct 9, 2023
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
please dont land w/out confirming its not fixed!
repokitteh-read-only
bot
removed
the
deps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…20)"
This reverts commit c495291.
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]