Merged
Conversation
added 2 commits
September 8, 2023 15:12
Signed-off-by: AlanDiaz <diazalan@google.com>
Signed-off-by: AlanDiaz <diazalan@google.com>
Contributor
Author
|
@ggreenway This is another PR to continue moving over filters to the new getOrCreateRawAsyncClient method. |
ggreenway
requested changes
Sep 11, 2023
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
A few nits, but looks good overall
/wait
envoy/grpc/async_client_manager.h
Outdated
|
|
||
| const envoy::config::core::v3::GrpcService& config() const { return config_; } | ||
|
|
||
| void mergeConfig(const envoy::config::core::v3::GrpcService g) { |
Member
There was a problem hiding this comment.
Suggested change
| void mergeConfig(const envoy::config::core::v3::GrpcService g) { | |
| void setConfig(const envoy::config::core::v3::GrpcService g) { |
Or maybe updateConfig?
Contributor
Author
There was a problem hiding this comment.
I changed it to setConfig because I feel like that fits the use case better than update.
envoy/grpc/async_client_manager.h
Outdated
|
|
||
| class GrpcServiceConfigWithHashKey { | ||
| public: | ||
| GrpcServiceConfigWithHashKey(){}; |
Member
There was a problem hiding this comment.
Suggested change
| GrpcServiceConfigWithHashKey(){}; | |
| GrpcServiceConfigWithHashKey() = default; |
Signed-off-by: AlanDiaz <diazalan@google.com>
ggreenway
approved these changes
Sep 11, 2023
tyxia
reviewed
Nov 2, 2023
| const envoy::config::core::v3::GrpcService& grpc_service) | ||
| : config_(config), client_(std::move(client)), stats_(config->stats()), | ||
| grpc_service_(grpc_service), decoding_state_(*this, config->processingMode()), | ||
| grpc_service_(grpc_service), config_with_hash_key_(grpc_service), |
Member
There was a problem hiding this comment.
@DiazAlan grpc_service_ seems to be replaced by config_with_hash_key_, more specifically config_with_hash_key_.config().
Then it can be removed?
(Just noticed this when I am currently looking at ext_proc client)
ashishb-90
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Nov 30, 2023
Change API call on ext_proc to more efficient new implementation. Following the PR envoyproxy#29199, we are replacing the API call in ext_proc so it's not hashing the whole config proto on each request. Signed-off-by: AlanDiaz <diazalan@google.com>
ashishb-90
pushed a commit
to solo-io/envoy-fork
that referenced
this pull request
Nov 30, 2023
Change API call on ext_proc to more efficient new implementation. Following the PR envoyproxy#29199, we are replacing the API call in ext_proc so it's not hashing the whole config proto on each request. Signed-off-by: AlanDiaz <diazalan@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Change API call on ext_proc to more efficient new implementation
Additional Description: Following the PR #29199, we are replacing the API call in ext_proc so it's not hashing the whole proto on each request.