repo reorg: move network/HTTP ext_authz filters#2915
repo reorg: move network/HTTP ext_authz filters#2915mattklein123 wants to merge 4 commits intomasterfrom
Conversation
Demonstrates common code across multiple filters. Signed-off-by: Matt Klein <mklein@lyft.com>
|
Oops need to kill some |
| namespace Envoy { | ||
| namespace Extensions { | ||
| namespace Filters { | ||
| namespace Common { |
There was a problem hiding this comment.
This works well for ext_authz, +1. I'm wondering how you think this structure plays out when we have two HTTP filters with common code (rather than a network and an HTTP file sharing some common code)? Do we still use filters/common, or is there filters/http/common?
There was a problem hiding this comment.
I was planning on doing filters/http/common and I would do Extensions::HttpFilters::Common::.
There was a problem hiding this comment.
I would find it really helpful if we had it documented somewhere what goes where and why, as part of this series of PRs. Internally we have a requirements on BUILD files they have a top level comment on what goes where but many of our intermediate directories don't have BUILD files (yet). I'm open to BUILD files in the "empty" directories, or FOO.md files, or a REPO_ORGANIZATION file in a top level directory, or comments on each module why they live where they live, whatever works!
There was a problem hiding this comment.
I'm going to go ahead and add a REPO_ORGANIZATION.md to the top level in this PR. I think that's a great idea.
Signed-off-by: Matt Klein <mklein@lyft.com>
|
Closing temporarily until I get the doc in place. |
|
Oops I guess I can't reopen this. Will open a new one. |
3 participants
Demonstrates common code across multiple filters.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A