tracing: Deprecate Opencensus (@1.30)#29063
Conversation
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
cc @kyessenov |
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Per offline discussions.
phlax
force-pushed
the
deprecate-opencensus
branch
from
dc4c9b2 to
e33ce96
Compare
phlax
changed the title
phlax
force-pushed
the
deprecate-opencensus
branch
2 times, most recently
from
dd7bd19 to
60dbc3f
Compare
phlax
changed the title
basvanbeek
left a comment
basvanbeek
left a comment
There was a problem hiding this comment.
I'm happy we're first deprecating with a notice. Personally I feel the OpenCensus project has been archived too early as OpenTelemetry has not been great at getting to production readiness (especially metrics in Go). But I do believe their decision has made it inevitable for us to get rid of non maintained code with some sense of urgency. This strikes a good balance for people needing to switch over.
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
deprecate-opencensus
branch
from
60dbc3f to
1e739f0
Compare
phlax
changed the title
| @@ -48,29 +48,35 @@ message OpenCensusConfig { | |||
| reserved 7; | |||
There was a problem hiding this comment.
@htuch you may know why - the one thing i didnt manage to do was deprecate the enum above (in file)
not sure why - probs i was just doing it wrong
There was a problem hiding this comment.
It probably only matters that you deprecate the fields that reference it.
6 participants
related to #9958
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]