tracing: Deprecate OpenTracing#28987
Conversation
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
/assign @yanavlasov |
|
I think some tests needs to use DEPRECATED_FEATURE_TEST to pass in the compile time options build. |
|
/wait |
Signed-off-by: Ryan Hamilton <rch@google.com>
Oh thanks! I didn't know that was a thing! Done. |
|
/retest |
| // <https://github.com/opentracing/opentracing-cpp>`_. | ||
| string library = 1 [(validate.rules).string = {min_len: 1}]; | ||
| string library = 1 [ | ||
| deprecated = true, |
There was a problem hiding this comment.
An observation is that we could set a message-level deprecated annotation, but I'm guessing we would have to update some of the code for warning on this use of deprecated. Not strictly needed here, as to use this filter you need to set some stuff. But, for an empty filter config it would be needed in the future.
There was a problem hiding this comment.
Yeah, I had exactly the same thought. I'm inclined to leave that out of this PR and address it if/when we have an empty filter config to deprecate.
| Tracing::DriverSharedPtr DynamicOpenTracingTracerFactory::createTracerDriverTyped( | ||
| const envoy::config::trace::v3::DynamicOtConfig& proto_config, | ||
| Server::Configuration::TracerFactoryContext& context) { | ||
| ENVOY_LOG_MISC(warn, "OpenTracing is deprecated and will be removed soon."); |
There was a problem hiding this comment.
Shouldn't this be generated anyway via the use of the deprecated proto fields?
There was a problem hiding this comment.
Oh, fair point. I think I misread the suggestion on slack as saying we needed an explicit log in the factory. Reverted.
Signed-off-by: Ryan Hamilton <rch@google.com>
Signed-off-by: Ryan Hamilton <rch@google.com>
This reverts commit 494c716. Signed-off-by: Ryan Northey <ryan@synca.io>
4 participants
The OpenTracing upstream project has been abandoned, as noted in #27401.
Consequently this library is not receiving security updates and is not compatible
with Envoy.
Risk Level: N/A
Testing: N/A
Docs Changes: Changelog updated
Release Notes: Changelog updated