edf-lb: internal refactor - convert hostWeight() to const#28464
Merged
KBaichoo merged 4 commits intoenvoyproxy:mainfrom Jul 27, 2023
Merged
edf-lb: internal refactor - convert hostWeight() to const#28464KBaichoo merged 4 commits intoenvoyproxy:mainfrom
KBaichoo merged 4 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
Contributor
Author
KBaichoo
approved these changes
Jul 19, 2023
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
KBaichoo
approved these changes
Jul 19, 2023
Contributor
|
/retest |
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
KBaichoo
approved these changes
Jul 21, 2023
Signed-off-by: Adi Suissa-Peleg <adip@google.com>
KBaichoo
approved these changes
Jul 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: edf-lb: internal refactor - convert hostWeight() to const
Additional Description:
The EDF LB implementation used a non-const method to compute the host weight, which doesn't seem to be necessary.
As part of this PR we removed the protected data member
aggression_assuming it is not needed anywhere.Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A - not user-facing change
Platform Specific Features: N/A