Skip to content

mobile: running compile time options build on all Envoy PRs#27707

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:test_ci
Jun 6, 2023
Merged

mobile: running compile time options build on all Envoy PRs#27707
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:test_ci

Conversation

@alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented May 30, 2023

the no-YAML build is easy to break and we've move this off the constrained machines.

@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #27707 was opened by alyssawilk.

see: more, trace.

@phlax
Copy link
Member

phlax commented Jun 5, 2023

@alyssawilk i dont think this would trigger the necessary tests - we could add this file to the trigger files

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk alyssawilk changed the title ci: verify that breaking the EM yaml build fails presubmit mobile: running compile time options build on all Envoy PRs Jun 5, 2023
@alyssawilk alyssawilk marked this pull request as ready for review June 5, 2023 15:44
@alyssawilk alyssawilk enabled auto-merge (squash) June 5, 2023 15:44
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk

i think we should move this together with the other always run jobs - its difficult to know what does/not run unless you know the code or track through the ci actions on an event - aside other benefits putting them together should make that a bit clearer

@RyanTheOptimist
Copy link
Contributor

lgtm, thanks @alyssawilk

i think we should move this together with the other always run jobs - its difficult to know what does/not run unless you know the code or track through the ci actions on an event - aside other benefits putting them together should make that a bit clearer

By move, do you mean reorder the contents of the .yml file, or something else?

@phlax
Copy link
Member

phlax commented Jun 5, 2023

By move, do you mean reorder the contents of the .yml file, or something else?

currently all of the jobs in mobile-perf.yml, and mobile-docs.yml are always run, and now also this one job from this workflow

im suggesting placing all of these jobs in a single workflow

@alyssawilk
Copy link
Contributor Author

/retest

@alyssawilk alyssawilk merged commit bbcc855 into envoyproxy:main Jun 6, 2023
asheryerm pushed a commit to asheryerm/envoy that referenced this pull request Jul 5, 2023
…xy#27707)

the no-YAML build is easy to break and we've move this off the constrained machines.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: asheryer <asheryer@amazon.com>
reskin89 pushed a commit to reskin89/envoy that referenced this pull request Jul 11, 2023
…xy#27707)

the no-YAML build is easy to break and we've move this off the constrained machines.

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Ryan Eskin <ryan.eskin89@protonmail.com>
@alyssawilk alyssawilk deleted the test_ci branch March 19, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants