Skip to content

build: fix merge break on master in #2416.#2646

Merged
htuch merged 3 commits intoenvoyproxy:masterfrom
htuch:fix-master
Feb 20, 2018
Merged

build: fix merge break on master in #2416.#2646
htuch merged 3 commits intoenvoyproxy:masterfrom
htuch:fix-master

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Feb 20, 2018

Root cause: PR was not up-to-date when merging.

Signed-off-by: Harvey Tuch htuch@google.com

Root cause: PR was not up-to-date when merging.

Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Feb 20, 2018

@saumoh @danielhochman

dnoe
dnoe previously approved these changes Feb 20, 2018
Signed-off-by: Harvey Tuch <htuch@google.com>
dnoe
dnoe previously approved these changes Feb 20, 2018
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch merged commit 38d8271 into envoyproxy:master Feb 20, 2018
@htuch htuch deleted the fix-master branch February 20, 2018 16:08
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants