Skip to content

hot-restarter.py: revert SIGCHLD handler to force kill instead of term #2640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 1 commit into from
Feb 22, 2018
Merged

hot-restarter.py: revert SIGCHLD handler to force kill instead of term #2640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions restarter/hot-restarter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,12 @@ def sigchld_handler(signum, frame):
kill_all_and_exit = True

if kill_all_and_exit:
print "Due to abnormal exit, terminating all child processes and exiting"
term_all_children()
print "Due to abnormal exit, force killing all child processes and exiting"

# First uninstall the SIGCHLD handler so that we don't get called again.
signal.signal(signal.SIGCHLD, signal.SIG_DFL)

force_kill_all_children()

# Our last child died, so we have no purpose. Exit.
if not pid_list:
Expand Down