check_format: use GOPATH and add install commands for formatting libraries#2608
Merged
htuch merged 6 commits intoenvoyproxy:masterfrom Feb 16, 2018
Merged
check_format: use GOPATH and add install commands for formatting libraries#2608htuch merged 6 commits intoenvoyproxy:masterfrom
htuch merged 6 commits intoenvoyproxy:masterfrom
Conversation
added 2 commits
February 14, 2018 13:09
These tools are referenced in various doc locations and unless you specify the -5.0 you likely will end up with the wrong clang-format library. Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
The buildifier docs recommend using the go toolchain to install buildifier. Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
bazel/README.md
Outdated
| 4. `bazel fetch //source/...` to fetch and build all external dependencies. This may take some time. | ||
| 5. `bazel build //source/exe:envoy-static` from the Envoy source directory. | ||
| and also for [Buildifer](https://github.com/bazelbuild/buildtools) which is used for formatting bazel BUILD files. | ||
| 4. `go get go get github.com/bazelbuild/buildtools/buildifier` to install buildifier |
Contributor
|
nice. i was lazy and symlinked buildifier into |
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Member
Author
|
@danielhochman :P looks like this was also being leveraged by a container somewhere, looking where now |
added 2 commits
February 14, 2018 14:14
Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
BUILDIFIER_BIN is used within several shell scripts already and the default should work if not set. Signed-off-by: Christopher M. Luciano <cmluciano@us.ibm.com>
Member
|
Please merge master to pick up #2613, this should fix CI TSAN. |
Member
Author
|
ok fingers crossed on merging of master |
htuch
reviewed
Feb 15, 2018
| 4. `bazel fetch //source/...` to fetch and build all external dependencies. This may take some time. | ||
| 5. `bazel build //source/exe:envoy-static` from the Envoy source directory. | ||
| and also for [Buildifer](https://github.com/bazelbuild/buildtools) which is used for formatting bazel BUILD files. | ||
| 4. `go get github.com/bazelbuild/buildtools/buildifier` to install buildifier |
Member
Author
There was a problem hiding this comment.
Should we split the OS stuff out into a unique heading?
Member
There was a problem hiding this comment.
Never mind, I was reading this incorrectly via the GH diffs, looks good.
htuch
approved these changes
Feb 16, 2018
| 4. `bazel fetch //source/...` to fetch and build all external dependencies. This may take some time. | ||
| 5. `bazel build //source/exe:envoy-static` from the Envoy source directory. | ||
| and also for [Buildifer](https://github.com/bazelbuild/buildtools) which is used for formatting bazel BUILD files. | ||
| 4. `go get github.com/bazelbuild/buildtools/buildifier` to install buildifier |
Member
There was a problem hiding this comment.
Never mind, I was reading this incorrectly via the GH diffs, looks good.
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Update Cronvoy config so it picks up the new defaults. Fixes envoyproxy/envoy-mobile#2600. Risk Level: Low Testing: existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Renjie Tang <renjietang@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Update Cronvoy config so it picks up the new defaults. Fixes envoyproxy/envoy-mobile#2600. Risk Level: Low Testing: existing tests Docs Changes: n/a Release Notes: n/a Signed-off-by: Renjie Tang <renjietang@chromium.org> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: check_format: use GOPATH and add install commands for formatting libraries
Description:
The buildifier docs recommend using the go toolchain to install buildifier. I'm not sure if current default just reflects the original authors GOPATH.
I added explicit installation instructions else
./tools/check_format.shmay fail for a new contributor with errors that seemingly indicate an actual format error.Risk Level: Low
Testing:
passing locally with
./tools/check_format.sh check