mobile: Add the stats prefix to the ADS xDS registration#25560
Merged
abeyad merged 1 commit intoenvoyproxy:mainfrom Feb 15, 2023
Merged
mobile: Add the stats prefix to the ADS xDS registration#25560abeyad merged 1 commit intoenvoyproxy:mainfrom
abeyad merged 1 commit intoenvoyproxy:mainfrom
Conversation
The stats_prefix field in the GoogleGrpc config has a proto validation rule that the field must be populated and have a length of at least 1. This change adds the stat_prefix field whenever the ADS builder API is used, and adds tests to validate it. Lastly, this change makes the mobile_compile_time_options CI job turn on proto validation, so we can ensure we never commit invalid proto, even though mobile normally disables proto validation for binary size purposes. The default value for the PVG template is the empty string (https://github.com/bufbuild/protoc-gen-validate/blob/38260ee45796b420276ac925d826ecec8fc3e9a8/bazel/BUILD#L11), so the mobile_compile_time_options sets template-flavor to the empty string instead of the default `nop` for mobile. Signed-off-by: Ali Beyad <abeyad@google.com>
abeyad
requested review from
Augustyniak,
RyanTheOptimist,
alyssawilk and
jpsim
as code owners
RyanTheOptimist
approved these changes
Feb 14, 2023
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
Thanks for doing this!
jpsim
approved these changes
Feb 14, 2023
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stats_prefix field in the GoogleGrpc config has a proto validation rule that the field must be populated and have a length of at least 1.
This change adds the stat_prefix field whenever the ADS builder API is used, and adds tests to validate it.
Lastly, this change makes the mobile_compile_time_options CI job turn on proto validation, so we can ensure we never commit invalid proto, even though mobile normally disables proto validation for binary size purposes. The default value for the PVG template is the empty string (https://github.com/bufbuild/protoc-gen-validate/blob/38260ee45796b420276ac925d826ecec8fc3e9a8/bazel/BUILD#L11), so the mobile_compile_time_options sets template-flavor to the empty string instead of the default
nopfor mobile.Signed-off-by: Ali Beyad abeyad@google.com