Skip to content

deps: Bump Envoy pytooling deps#25242

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-bump-python
Feb 1, 2023
Merged

deps: Bump Envoy pytooling deps#25242
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:deps-bump-python

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Jan 30, 2023

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 30, 2023
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).
envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: #25242 was opened by phlax.

see: more, trace.

@phlax phlax changed the title deps: Bump Envoy pytooling deps [WIP] deps: Bump Envoy pytooling deps Jan 30, 2023
@phlax phlax marked this pull request as draft January 30, 2023 13:49
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Jan 30, 2023

python's packaging removed the LegacyVersion which could handle any version string - i naively thought i could just remove it, but it seems it will require some further error/type handling to make this work

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 30, 2023
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Feb 1, 2023
@phlax phlax changed the title [WIP] deps: Bump Envoy pytooling deps deps: Bump Envoy pytooling deps Feb 1, 2023
@phlax phlax marked this pull request as ready for review February 1, 2023 00:10
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 1, 2023

because of a small change to a core python api i have had to do quite a bit of testing - i think things mostly work in my dev HEAD so just trying to figure steps to update envoy

this has required updates from the packaging api change - docs changes have been separated out to #25257

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Feb 1, 2023

@RyanTheOptimist if you could give this one another look that would be great

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Feb 1, 2023
@phlax phlax merged commit 9a2c13e into envoyproxy:main Feb 1, 2023
phlax added a commit to phlax/envoy that referenced this pull request Feb 3, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 4, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit to phlax/envoy that referenced this pull request Feb 4, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
phlax added a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax added a commit that referenced this pull request Feb 6, 2023
Signed-off-by: Ryan Northey <ryan@synca.io>

Signed-off-by: phlax <phlax@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants