Shared mem hash set cleanup debug scaffolding#2510
Merged
ggreenway merged 5 commits intoenvoyproxy:masterfrom Feb 1, 2018
Merged
Shared mem hash set cleanup debug scaffolding#2510ggreenway merged 5 commits intoenvoyproxy:masterfrom
ggreenway merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ion(). Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…ion(). Signed-off-by: Joshua Marantz <jmarantz@google.com>
…b.com:jmarantz/envoy into shared-mem-hash-set-cleanup-debug-scaffolding Signed-off-by: Joshua Marantz <jmarantz@google.com>
ggreenway
approved these changes
Feb 1, 2018
Member
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
This is a nice cleanup.
I'm not sure what the policy is on friend class; I don't know that I've seen it used in envoy before, but I don't object to this use of it.
mattklein123
approved these changes
Feb 1, 2018
Member
mattklein123
left a comment
mattklein123
left a comment
There was a problem hiding this comment.
Nice, thanks. re: friend class, @ggreenway I suggested this. We do this in a few places and I think for this type of thing (test companion) it's a pretty clean way of splitting off this type of code.
Contributor
Author
|
Thanks for the quick review, Greg & Matt. |
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
…#2510) Signed-off-by: Piotr Sikora <piotrsikora@google.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: Forcing the use of IPv6 socket addresses is required to make Envoy Mobile work with some carriers when running on an Android device. The option was introduced upstream in #21803. Risk Level: Low, enabled a well tested option. Testing: Manual, launched the example app Docs Changes: Updated Release Notes: Updated Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: Forcing the use of IPv6 socket addresses is required to make Envoy Mobile work with some carriers when running on an Android device. The option was introduced upstream in #21803. Risk Level: Low, enabled a well tested option. Testing: Manual, launched the example app Docs Changes: Updated Release Notes: Updated Signed-off-by: Rafal Augustyniak <raugustyniak@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
String serialization of data structures moved to test class, loop-breaking conditionals statements moved to the for-loop conditional expression from the body.
Risk Level: Low
Testing: //test/... .passes.