load balancer: added maglev/ring hash load balancer extension#24896
Merged
wbpcode merged 15 commits intoenvoyproxy:mainfrom Jan 20, 2023
Merged
load balancer: added maglev/ring hash load balancer extension#24896wbpcode merged 15 commits intoenvoyproxy:mainfrom
wbpcode merged 15 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Member
Author
|
Ready for review. |
added 7 commits
January 12, 2023 04:21
…ig is set or LoadBalancingPolicyConfig is used Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
…itly Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
added 2 commits
January 13, 2023 04:50
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
added 2 commits
January 19, 2023 00:24
Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Member
Author
|
Main is merged and conflicts are resolved. cc @mattklein123 could you give a new LGTM? |
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
mattklein123
previously approved these changes
Jan 19, 2023
Member
Author
|
@mattklein123 conflict resolved again. orz. Please give a LGTM again, thanks. orz 🙏 |
Member
Author
|
hmmm, ci is flaky because the wasm. |
mattklein123
approved these changes
Jan 20, 2023
VishalDamgude
pushed a commit
to freshworks-oss/envoy
that referenced
this pull request
Feb 2, 2023
…roxy#24896) * load balancer: added maglev/ring hash load balancer extension Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix the possbile UH of ringhash/maglev when locality_weighted_lb_config is set or LoadBalancingPolicyConfig is used Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * minor update Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * remove uncessary stdout Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * enable locality weighted lb only when he configuration is set eexplicitly Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix format Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * add more test Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * fix windows build Signed-off-by: wbpcode <wangbaiping@corp.netease.com> * resolve cconflict Signed-off-by: wbpcode <wangbaiping@corp.netease.com> Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: load balancer: added maglev/ring hash load balancer extension
Additional Description:
Further work of #23472. Part of #20634.
Risk Level: Low.
Testing: unit, integration.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.