Skip to content

Clarify that on-demand CDS does not support SotW xDS #24763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KBaichoo merged 2 commits into from
Jan 10, 2023
Merged

Clarify that on-demand CDS does not support SotW xDS #24763

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f57f11
Clarify that on-demand CDS does not support SotW xDS
jewertow Jan 4, 2023
b46ac81
Update warning message
jewertow Jan 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions api/envoy/extensions/filters/http/on_demand/v3/on_demand.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,11 @@ option (udpa.annotations.file_status).package_version_status = ACTIVE;
// [#protodoc-title: On Demand Discovery]
// On Demand Discovery :ref:`configuration overview <config_http_filters_on_demand>`.
// [#extension: envoy.filters.http.on_demand]
//
// .. warning::
//
// On-demand CDS does not support SotW streams. Currently it only supports incremental xDS.
Comment thread
jewertow marked this conversation as resolved.
Outdated
//

// Configuration of on-demand CDS.
message OnDemandCds {
Expand Down