Revert "Update data-plane-api (#2430)"#2465
Merged
mattklein123 merged 2 commits intomasterfrom Jan 26, 2018
Merged
Conversation
This reverts commit d6b630a. Signed-off-by: Matt Klein <mklein@lyft.com>
Member
Author
|
@htuch @kyessenov I'm opening an issue also to describe the problem. Will link here. |
Member
Author
|
Underlying issue tracked here: #2466 |
Signed-off-by: Matt Klein <mklein@lyft.com>
ccaraman
approved these changes
Jan 26, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* feat(stackdriver): add support for gce_instance MR Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * fix typo Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * update logger and metrics code to be gce_instance aware Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * update missed golang test metadata Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * s/std::string/auto&/ Signed-off-by: Douglas Reid <douglas-reid@users.noreply.github.com> * clang-format * Revert "update missed golang test metadata" This reverts commit 2b157dfc2bec86980427a537dd9395ce54b23add. * Revert "Revert "update missed golang test metadata"" This reverts commit d0e99e96fb658013d9a92c2531bfd0ed4df05345. * Revert "clang-format" This reverts commit 0f3fbdb49ac7f26ca0fe5e1a9cea86b138ecf422. * Revert "s/std::string/auto&/" This reverts commit 441df9f82f0dc0945052952e9f924c7b6b1b79b0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d6b630a.