Skip to content

fixing coverage #24529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 4 commits into from
Dec 14, 2022
Merged

fixing coverage #24529

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d24418b
fixing coverage
alyssawilk Dec 14, 2022
32d86a8
all the things
alyssawilk Dec 14, 2022
b1e45ca
-
alyssawilk Dec 14, 2022
40d2ac6
workaround
alyssawilk Dec 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified test/per_file_coverage.sh
100644 → 100755
View file
Open in desktop
Empty file.
4 changes: 2 additions & 2 deletions test/run_envoy_bazel_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,9 +118,9 @@ fi
set +e
if [[ "$VALIDATE_COVERAGE" == "true" ]] && [[ "${FUZZ_COVERAGE}" == "false" ]]; then
echo "Checking per-extension coverage"
output=$(./test/per_file_coverage.sh)
output=$(sh ./test/per_file_coverage.sh)
Comment thread
phlax marked this conversation as resolved.
Outdated

if [ $? -eq 1 ]; then
if [ $? -ne 0 ]; then
echo Per-extension coverage failed:
echo "$output"
COVERAGE_FAILED=1
Expand Down