Add fstat and stat capabilities to async_files#24491
Merged
mattklein123 merged 25 commits intoenvoyproxy:mainfrom Dec 16, 2022
Merged
Add fstat and stat capabilities to async_files#24491mattklein123 merged 25 commits intoenvoyproxy:mainfrom
mattklein123 merged 25 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
(.circleci yaml CI failure) Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Signed-off-by: Raven Black <ravenblack@dropbox.com>
ravenblackx
changed the title
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Contributor
Author
|
Note status_helper changes could be reviewed separately/first in #24498 |
(past dependency envoyproxy#24498) Signed-off-by: Raven Black <ravenblack@dropbox.com>
Contributor
Author
|
status_helper change now merged in. |
(Past broken coverage) Signed-off-by: Raven Black <ravenblack@dropbox.com>
mattklein123
approved these changes
Dec 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add fstat and stat capabilities to async_files
Additional Description: For the sake of filesystem caching, it is useful to be able to measure an open file, or a non-open file, so that the size impact of deleting it can be easily accounted for in the cache size.
Risk Level: Very low. AsyncFileManager is only used in filters tagged as not-yet-safe, and this shouldn't change any live paths anyway.
Testing: 100% coverage.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: AsyncFileHandle is already not supported in Windows.