Deflake directory iterator for windows#24469
Merged
mattklein123 merged 3 commits intoenvoyproxy:mainfrom Dec 9, 2022
Merged
Conversation
Signed-off-by: Raven Black <ravenblack@dropbox.com>
jmarantz
previously approved these changes
Dec 9, 2022
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
lgtm modulo comment request.
Could merge w/o that of course to ease the flakes.
| } else if (find_data.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) { | ||
| return {std::string(find_data.cFileName), FileType::Directory, absl::nullopt}; | ||
| } else if (find_data.dwReserved0 & IO_REPARSE_TAG_SYMLINK) { | ||
| } else if ((find_data.dwFileAttributes & FILE_ATTRIBUTE_REPARSE_POINT) && |
Contributor
There was a problem hiding this comment.
can you add the link from the description into the source code here?
Signed-off-by: Raven Black <ravenblack@dropbox.com>
Sync past mobile_docs CI failure. Signed-off-by: Raven Black <ravenblack@dropbox.com>
jmarantz
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Deflake directory iterator for windows
Additional Description: #24176 made windows CI flaky - I mistakenly used a flag without checking if the prerequisite other flag that makes that flag meaningful was present. This fixes that.
Relevant documentation:
Risk Level: Negative.
Testing: CI should stop being flaky. Cannot test directly, no Windows.
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: It's Windows-only.