Skip to content

Moving more files into the listener manager directory.#24419

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:followup_api_listener
Dec 8, 2022
Merged

Moving more files into the listener manager directory.#24419
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:followup_api_listener

Conversation

@alyssawilk
Copy link
Contributor

@alyssawilk alyssawilk commented Dec 7, 2022

plus follow-ups from #24394

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24419 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk changed the title Movigg more files into the listener manager directory. Moving more files into the listener manager directory. Dec 7, 2022
@alyssawilk alyssawilk marked this pull request as ready for review December 7, 2022 19:36
@alyssawilk
Copy link
Contributor Author

(clang tidy error is legacy error)

Copy link
Contributor

@snowp snowp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Love the extra comments

@alyssawilk alyssawilk merged commit a6b767e into envoyproxy:main Dec 8, 2022
@alyssawilk alyssawilk deleted the followup_api_listener branch April 5, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants