swift: stop using loopback for direct responses#24402
swift: stop using loopback for direct responses#24402alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
CC @envoyproxy/coverage-shephards: FYI only for changes made to |
alyssawilk
force-pushed
the
remove_loopback_requirement
branch
3 times, most recently
from
6227056 to
0ef0598
Compare
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
alyssawilk
force-pushed
the
remove_loopback_requirement
branch
from
0ef0598 to
4ff414b
Compare
alyssawilk
changed the title
alyssawilk
requested review from
Augustyniak,
RyanTheOptimist,
abeyad and
jpsim
as code owners
|
cc @jpsim |
| - name: remote_service | ||
| domains: ["*"] | ||
| routes: | ||
| #{fake_remote_responses} |
There was a problem hiding this comment.
oh, I thought that we would be able to remove a bigger portion of this fake listener as part of this step. What's preventing us from doing that (apologies if you have explained it in the community sync meeting)?
There was a problem hiding this comment.
I was going to do that as a follow-up after I removed listener support so we can make sure it doesn't break Lyft tests first :-)
There was a problem hiding this comment.
so the plan is land this, then #24363 (working on a c-opt for legacy tests like the kotlin tests) then remove the listener entirely
4 participants
This changes swift's direct responses from being proxied upstream and handled by the "fake" (real) listener, to being handled locally, and bypassing the "do not forward local replies" logic in the onLocalReply classes
Commit Message: na/a
Additional Description: n/a
Risk Level: medium (mobile only)
Testing: existing tests
part of #24428