Skip to content

ci: changing android workflow wto always run but not always perform tests#24392

Closed
alyssawilk wants to merge 1 commit intoenvoyproxy:mainfrom
alyssawilk:always
Closed

ci: changing android workflow wto always run but not always perform tests#24392
alyssawilk wants to merge 1 commit intoenvoyproxy:mainfrom
alyssawilk:always

Conversation

@alyssawilk
Copy link
Contributor

…ests

Signed-off-by: Alyssa Wilk alyssar@chromium.org

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

…ests

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@repokitteh-read-only
Copy link

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #24392 was opened by alyssawilk.

see: more, trace.

@alyssawilk alyssawilk changed the title ci: changing android workflow wto always run but not alwasy perform t… ci: changing android workflow wto always run but not always perform tests Dec 6, 2022
@jpsim
Copy link
Contributor

jpsim commented Dec 6, 2022

What if we extracted this to a mobile/tools/should_run_ci.sh check that passed a --job parameter so we could reuse this in more places and consolidate the logic?

./mobile/tools/should_run_ci.sh --job kotlintestsmac

We could then tap into this to run the mobile CI jobs when deps change too.

I'm happy to tackle this if you're supportive of the direction.

@alyssawilk
Copy link
Contributor Author

sure, SGTM, and thanks for offering to pick it up (this is about as much workflow logic as I know how to handle =P)

@alyssawilk alyssawilk closed this Dec 6, 2022
@jpsim
Copy link
Contributor

jpsim commented Dec 7, 2022

#24407

@alyssawilk alyssawilk deleted the always branch April 5, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants