Skip to content

ci: Skip build/release jobs if only mobile or docs changed#24383

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-change-conditions
Dec 12, 2022
Merged

ci: Skip build/release jobs if only mobile or docs changed#24383
phlax merged 1 commit intoenvoyproxy:mainfrom
phlax:ci-change-conditions

Conversation

@phlax
Copy link
Member

@phlax phlax commented Dec 6, 2022

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax
Copy link
Member Author

phlax commented Dec 6, 2022

@alyssawilk this will require a similar change to the required jobs release -> released for each of x64/arm64

alyssawilk
alyssawilk previously approved these changes Dec 6, 2022
alyssawilk
alyssawilk previously approved these changes Dec 6, 2022
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though @jpsim or @lizan might actually be able to catch errors =P

@phlax
Copy link
Member Author

phlax commented Dec 6, 2022

just realizing we need to skip docker also if these are skipped as it uses their artefacts

@phlax phlax marked this pull request as draft December 6, 2022 22:45
@phlax phlax changed the title ci: Skip build/release jobs if only mobile or docs changed [WIP] ci: Skip build/release jobs if only mobile or docs changed Dec 6, 2022
@phlax
Copy link
Member Author

phlax commented Dec 7, 2022

checking through the affected pipelines i think we need to tackle the docker and verify stages first

@phlax
Copy link
Member Author

phlax commented Dec 7, 2022

ive opened #24417 to tackle ^^ first

@phlax
Copy link
Member Author

phlax commented Dec 8, 2022

required changes:

  • linux_x64 release -> linux_x64 released
  • linux_arm64 release -> linux_arm64 released
  • windows release -> windows released

remove:

  • windows docker windows2019
  • windows docker windows2022

(EDIT: removed macos as its not currently required)

@phlax phlax changed the title [WIP] ci: Skip build/release jobs if only mobile or docs changed ci: Skip build/release jobs if only mobile or docs changed Dec 8, 2022
@phlax phlax marked this pull request as ready for review December 8, 2022 10:37
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the ci-change-conditions branch from 52b90ae to 009de00 Compare December 8, 2022 10:42
@phlax phlax merged commit 55554df into envoyproxy:main Dec 12, 2022
jpsim added a commit that referenced this pull request Dec 12, 2022
…s-in-mobile_docs-job

* origin/main:
  ci: Skip build/release jobs if only mobile or docs changed (#24383)

Signed-off-by: JP Simard <jp@jpsim.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants