coverage: adding tests, bumping up

source/extensions/clusters/common/logical_host.h

@@ -42,13 +42,12 @@ class LogicalHost : public HostImpl {
                        const envoy::config::endpoint::v3::LbEndpoint& lb_endpoint) {
     const auto& health_check_config = lb_endpoint.endpoint().health_check_config();
     auto health_check_address = resolveHealthCheckAddress(health_check_config, address);
-
     absl::WriterMutexLock lock(&address_lock_);
     setAddress(address);
     setAddressList(address_list);
-    // TODO: the health checker only gets the first address in the list and
-    // will not walk the full happy eyeballs list. We should eventually fix
-    // this.
+    /* TODO: the health checker only gets the first address in the list and
+     * will not walk the full happy eyeballs list. We should eventually fix
+     * this. */
     setHealthCheckAddress(health_check_address);
   }
 

test/extensions/clusters/common/BUILD

@@ -0,0 +1,18 @@
+load(
+    "//bazel:envoy_build_system.bzl",
+    "envoy_cc_test",
+    "envoy_package",
+)
+
+licenses(["notice"])  # Apache 2
+
+envoy_package()
+
+envoy_cc_test(
+    name = "logical_host_test",
+    srcs = ["logical_host_test.cc"],
+    deps = [
+        "//source/extensions/clusters/common:logical_host_lib",
+        "//test/mocks/upstream:host_mocks",
+    ],
+)

test/extensions/clusters/common/logical_host_test.cc

@@ -0,0 +1,47 @@
+#include "source/extensions/clusters/common/logical_host.h"
+
+#include "test/mocks/upstream/host.h"
+
+#include "gmock/gmock.h"
+#include "gtest/gtest.h"
+
+using testing::_;
+using testing::ReturnRef;
+
+namespace Envoy {
+namespace Extensions {
+namespace Clusters {
+
+class RealHostDescription : public testing::Test {
+public:
+  Network::Address::InstanceConstSharedPtr address_ = nullptr;
+  Upstream::MockHost* mock_host_{new NiceMock<Upstream::MockHost>()};
+  Upstream::HostConstSharedPtr host_{mock_host_};
+  Upstream::RealHostDescription description_{address_, host_};
+};
+
+TEST_F(RealHostDescription, UnitTest) {
+  // No-op unit tests
+  description_.canary();
+  description_.metadata();
+  description_.priority();
+  EXPECT_EQ(nullptr, description_.healthCheckAddress());
+
+  // Pass through functions
+  EXPECT_CALL(*mock_host_, transportSocketFactory());
+  description_.transportSocketFactory();
+
+  EXPECT_CALL(*mock_host_, canCreateConnection(_));
+  description_.canCreateConnection(Upstream::ResourcePriority::Default);
+
+  EXPECT_CALL(*mock_host_, loadMetricStats());
+  description_.loadMetricStats();
+
+  std::vector<Network::Address::InstanceConstSharedPtr> address_list;
+  EXPECT_CALL(*mock_host_, addressList()).WillOnce(ReturnRef(address_list));
+  description_.addressList();
+}
+
+} // namespace Clusters
+} // namespace Extensions
+} // namespace Envoy

test/per_file_coverage.sh

@@ -35,7 +35,6 @@ declare -a KNOWN_LOW_COVERAGE=(
 "source/common/watchdog:58.6" # Death tests don't report LCOV
 "source/exe:92.6"
 "source/extensions/access_loggers/wasm:93.5"
-"source/extensions/clusters/common:68.2"
 "source/extensions/common:92.9"
 "source/extensions/common/tap:92.9"
 "source/extensions/common/wasm:87.5" # flaky: be careful adjusting