ci: Fix change detection (part 3) #24347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Northey <[email protected]>
|
@alyssawilk the idea with this Pr is that we remove all the requirements on checks from branch protection and replace them with just the |
alyssawilk
reviewed
Dec 5, 2022
| vmImage: "ubuntu-20.04" | ||
| condition: | | ||
| and( | ||
| in(dependencies.bazel.result, 'Succeeded', 'SucceededWithIssues', 'Skipped'), |
There was a problem hiding this comment.
Can we comment about this job and how it works inline? I would assume that SucceededWithIssues would be bad and not grouped with the other two.
/wait
There was a problem hiding this comment.
i think we need SucceededWithIssues - not sure exactly what it does but this condition is functionally equivalent to using the succeeded() queue time var
that is my interpretation of:
succeeded() == in(variables['Agent.JobStatus'], 'Succeeded', 'SucceededWithIssues')
Signed-off-by: Ryan Northey <[email protected]>
phlax
force-pushed
the
ci-change-detection-4
branch
from
f3c3972
to
8775707
Compare
alyssawilk
approved these changes
Dec 6, 2022
jpsim
added a commit
that referenced
this pull request
Dec 6, 2022
…to-pull-bazelisk-1.15.0 * origin/main: coverage: fixing a TODO (#24357) ci: Fix change detection (part 3) (#24347) wasm: Improve the coverage report for Wasm (#23055) coverage: adding tests, bumping up (#24351) Signed-off-by: JP Simard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey [email protected]
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]