Skip to content

Store DNS answers in map instead of unordered map #24330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jwendell wants to merge 1 commit into from
Closed

Store DNS answers in map instead of unordered map #24330

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/extensions/filters/udp/dns_filter/dns_parser.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ class DnsAnswerRecord : public BaseDnsRecord {
};

using DnsAnswerRecordPtr = std::unique_ptr<DnsAnswerRecord>;
using DnsAnswerMap = std::unordered_multimap<std::string, DnsAnswerRecordPtr>;
using DnsAnswerMap = std::multimap<std::string, DnsAnswerRecordPtr>;

/**
* DnsSrvRecord represents a single answer record for a service which is to be serialized and
Expand Down
1 change: 0 additions & 1 deletion test/extensions/filters/udp/dns_filter/dns_filter_test_utils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,7 +237,6 @@ bool DnsResponseValidator::validateDnsResponseObject(DnsQueryContextPtr& context

bool DnsResponseValidator::parseAnswerRecords(DnsAnswerMap& answers, const uint16_t answer_count,
const Buffer::InstancePtr& buffer, uint64_t& offset) {
answers.reserve(answer_count);
for (auto index = 0; index < answer_count; index++) {
ENVOY_LOG(trace, "Parsing [{}/{}] answers", index, answer_count);
auto rec = parseDnsAnswerRecord(buffer, offset);
Expand Down