Skip to content

envoy: creating a stripped main base without validation server #24294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 15 commits into from
Dec 9, 2022
Merged

envoy: creating a stripped main base without validation server #24294

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
f491191
build: splitting main and main common
alyssawilk Dec 1, 2022
8cbc364
Merge branch 'main' into validation_server
alyssawilk Dec 6, 2022
344500a
comment
alyssawilk Dec 6, 2022
a547f2f
comment now without typo
alyssawilk Dec 6, 2022
49260c0
build fix
alyssawilk Dec 7, 2022
be2b8b5
yet another main
alyssawilk Dec 7, 2022
1c8847b
mobile format
alyssawilk Dec 7, 2022
e1c747b
comments
alyssawilk Dec 7, 2022
9296ff7
hopefully fix ci
alyssawilk Dec 7, 2022
02b8da5
build clean up
alyssawilk Dec 8, 2022
0b850c6
Merge branch 'main' into validation_server
alyssawilk Dec 8, 2022
ea8cb41
another coverage fix attempt
alyssawilk Dec 8, 2022
486a3e2
Merge branch 'main' into validation_server
alyssawilk Dec 8, 2022
47ad431
coverage
alyssawilk Dec 8, 2022
4d75b93
Merge branch 'main' into validation_server
alyssawilk Dec 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions source/exe/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ envoy_cc_library(
"//source/server:options_lib",
"//source/server:server_lib",
"//source/server:listener_hooks_lib",
"//source/server/config_validation:server_lib",
] + envoy_all_core_extensions() +
# TODO(rojkov): drop io_uring dependency when it's fully integrated.
select({
Expand All @@ -150,25 +149,21 @@ envoy_cc_library(

envoy_cc_library(
name = "envoy_main_common_with_core_extensions_lib",
srcs = [
"main_common.cc",
],
hdrs = [
"main_common.h",
],
srcs = ["main_common.cc"],
hdrs = ["main_common.h"],
deps = [
"//source/server/config_validation:server_lib",

@alyssawilk alyssawilk Dec 8, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @phlax I think this version should not have passed format checks. Did we lose buildifier on our format checks?

@phlax phlax Dec 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i believe it works the same as it always did

afaict the queue was cancelled before the check was run

it the ./tools/code_format/check_format.py script that runs it i think

":stripped_main_base_lib",
":envoy_common_with_core_extensions_lib",
":platform_impl_lib",
":process_wide_lib",
":stripped_main_base_lib",
"//envoy/server:platform_interface",
"//source/common/api:os_sys_calls_lib",
"//source/common/common:compiler_requirements_lib",
"//source/common/common:perf_annotation_lib",
"//source/common/grpc:google_grpc_context_lib",
"//source/server:hot_restart_lib",
"//source/server:hot_restart_nop_lib",
"//source/server/config_validation:server_lib",
] + select({
"//bazel:disable_signal_trace": [],
"//conditions:default": [
Expand Down