bazel: fix config_setting visibility issues#24237
Merged
keith merged 1 commit intoenvoyproxy:mainfrom Nov 29, 2022
Merged
Conversation
This pulls in a googleurl patch that's waiting on upstream, and updates rules_go for compatibility with this flag. This also flips it early so we don't regress before it's flipped upstream. Fixes envoyproxy#24183 Signed-off-by: Keith Smiley <keithbsmiley@gmail.com>
repokitteh-read-only
bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
RyanTheOptimist
approved these changes
Nov 29, 2022
Contributor
RyanTheOptimist
left a comment
RyanTheOptimist
left a comment
There was a problem hiding this comment.
LGTM, though this PR is marked as draft so maybe it's not actually ready?
repokitteh-read-only
bot
removed
the
deps
Member
Author
|
thanks! was just a draft in case of more surprises |
| build --test_summary=terse | ||
|
|
||
| # TODO(keith): Remove once this is the default | ||
| build --incompatible_config_setting_private_default_visibility |
Contributor
There was a problem hiding this comment.
You probably have to enable --incompatible_enforce_config_setting_visibility as well to make sure this actually take effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in a googleurl patch that's waiting on upstream, and updates rules_go for compatibility with this flag. This also flips it early so we don't regress before it's flipped upstream.
Fixes #24183
Signed-off-by: Keith Smiley keithbsmiley@gmail.com