owners: more details and on-call#2419
Merged
mattklein123 merged 3 commits intomasterfrom Jan 22, 2018
Merged
Conversation
Signed-off-by: Matt Klein <mklein@lyft.com>
htuch
reviewed
Jan 19, 2018
OWNERS.md
Outdated
| * Catch-all, "all the things", and generally trying to make himself obsolete as fast as | ||
| possible. | ||
| * Harvey Tuch ([htuch](https://github.com/htuch)) (htuch@google.com) | ||
| * APIs, xDS, gRPC, configuration, and Bazel/build. |
Member
There was a problem hiding this comment.
I'm also happy to cover some of the same topics that @dnoe is expert in, since I've been involved to some extent in either hacking around with or reviewing a lot of these. Also, I can tackle Python and bash fu.
PiotrSikora
reviewed
Jan 19, 2018
OWNERS.md
Outdated
| matter expert reviews. Feel free to loop them in as needed. | ||
|
|
||
| * Piotr Sikora ([PiotrSikora](https://github.com/PiotrSikora)) (piotrsikora@google.com) | ||
| * TLS, boringssl, and core networking (listeners, connections, etc.). |
Contributor
There was a problem hiding this comment.
s/boringssl/BoringSSL/, looks good otherwise, thanks!
lizan
approved these changes
Jan 19, 2018
Member
lizan
left a comment
lizan
left a comment
There was a problem hiding this comment.
LGTM. I like the term "Friends of Envoy" :)
zuercher
previously approved these changes
Jan 20, 2018
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
One small thing, but otherwise lgtm
OWNERS.md
Outdated
| * Daniel Hochman ([danielhochman](https://github.com/danielhochman)) (dhochman@lyft.com) | ||
| * Redis, Python, configuration/operational questions. | ||
| * Stephan Zuercher ([zuercher](https://github.com/zuercher)) (stephan@turbinelabs.io) | ||
| * Load balancing, upstream clusters and cluster manager, logging, and complex HTTP routing |
Member
There was a problem hiding this comment.
Might as well toss OSX build on this list. 😬
Signed-off-by: Matt Klein <mklein@lyft.com>
PiotrSikora
approved these changes
Jan 22, 2018
htuch
approved these changes
Jan 22, 2018
alyssawilk
approved these changes
Jan 22, 2018
jmillikin-stripe
approved these changes
Jan 22, 2018
Shikugawa
pushed a commit
to Shikugawa/envoy
that referenced
this pull request
Mar 28, 2020
* Removed unused istio.deps file * Removed references to istio.deps
jpsim
added a commit
that referenced
this pull request
Nov 28, 2022
For non-Apple platforms like Linux and Android. Updated the Kotlin, Java & C++ builders. Added here: #22080 Risk Level: Low to moderate, off by default but I had to refactor some stuff. Testing: Added. Docs Changes: Documentation comments. Release Notes: Added. Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
added a commit
that referenced
this pull request
Nov 29, 2022
For non-Apple platforms like Linux and Android. Updated the Kotlin, Java & C++ builders. Added here: #22080 Risk Level: Low to moderate, off by default but I had to refactor some stuff. Testing: Added. Docs Changes: Documentation comments. Release Notes: Added. Signed-off-by: JP Simard <jp@jpsim.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@envoyproxy/maintainers PTAL and let me know if I missed anything that people feel they want to be listed as experts on.
@PiotrSikora @rshriram @lizan @jmillikin-stripe I listed you as "friends of Envoy." LMK if you would prefer to be removed.