Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #24160

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Fix typo #24160

merged 1 commit into from
Nov 23, 2022

Conversation

ZiyangXiao
Copy link
Contributor

Signed-off-by: Xiao, Ziyang [email protected]

Commit Message: Fix typo in bazel/README.md
Additional Description:
Risk Level:low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Xiao, Ziyang <[email protected]>
@ZiyangXiao
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24160 (comment) was created by @ZiyangXiao.

see: more, trace.

Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @ZiyangXiao

@phlax
Copy link
Member

phlax commented Nov 23, 2022

unfortunately the coverage fail is broken CI from updating rust - im gonna take a look now and try fix forward or revert

@phlax
Copy link
Member

phlax commented Nov 23, 2022

ci bug is here #24164

@phlax phlax self-assigned this Nov 23, 2022
@phlax
Copy link
Member

phlax commented Nov 23, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #24160 (comment) was created by @phlax.

see: more, trace.

@phlax phlax merged commit 3e6e6c8 into envoyproxy:main Nov 23, 2022
@ZiyangXiao ZiyangXiao deleted the main-fix-typo branch November 25, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants