[backport/1.22] Release 1.22 build fix#23951
Merged
phlax merged 2 commits intoenvoyproxy:release/v1.22from Nov 16, 2022
Merged
Conversation
repokitteh-read-only
Bot
added
the
deps
|
CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to |
Member
Author
|
/wait for #23842 |
phlax
changed the title
Member
Author
|
/retest |
|
Retrying Azure Pipelines: |
As noted in envoyproxy#21060, building with gcc in "opt" mode results in a compilation error: ``` ERROR: /workspaces/envoy/source/common/config/BUILD:414:17: Compiling source/common/config/watch_map.cc failed: (Exit 1): gcc failed: error executing command /usr/bin/gcc -U_FORTIFY_SOURCE -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -g0 -O2 '-D_FORTIFY_SOURCE=1' -DNDEBUG -ffunction-sections ... (remaining 154 arguments skipped) Use --sandbox_debug to see verbose messages from the sandbox source/common/config/watch_map.cc: In member function 'virtual void Envoy::Config::WatchMap::onConfigUpdate(const google::protobuf::RepeatedPtrField<envoy::service::discovery::v3::Resource>&, const google::protobuf::RepeatedPtrField<std::__cxx11::basic_string<char> >&, const string&)': source/common/config/watch_map.cc:215:69: error: dereferencing type-punned pointer will break strict-aliasing rules [-Werror=strict-aliasing] 215 | type_url_, reinterpret_cast<std::vector<DecodedResourcePtr>&>(decoded_resources), | ^~~~~~~~~~~~~~~~~ cc1plus: all warnings being treated as errors ``` This PR changes the type of the original vector to be the base class type. Risk Level: Low-Medium (no features changes, but updates config-plane code). Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Adi Suissa-Peleg <adip@google.com> Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
release-1.22-build-fix
branch
from
02a3dee to
77f0f31
Compare
phlax
changed the title
Member
Author
|
cc @adisuissa |
mattklein123
approved these changes
Nov 15, 2022
…22-build-fix Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #23156
Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]