Skip to content

build: Make the mobile package visible only to other mobile dirs#23935

Merged
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
abeyad:mobile_visibility
Nov 14, 2022
Merged

build: Make the mobile package visible only to other mobile dirs#23935
alyssawilk merged 3 commits intoenvoyproxy:mainfrom
abeyad:mobile_visibility

Conversation

@abeyad
Copy link
Contributor

@abeyad abeyad commented Nov 10, 2022

Signed-off-by: Ali Beyad abeyad@google.com

Signed-off-by: Ali Beyad <abeyad@google.com>
@abeyad abeyad requested a review from alyssawilk November 10, 2022 16:51
Signed-off-by: Ali Beyad <abeyad@google.com>
@abeyad
Copy link
Contributor Author

abeyad commented Nov 10, 2022

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23935 (comment) was created by @abeyad.

see: more, trace.

Signed-off-by: Ali Beyad <abeyad@google.com>
@abeyad abeyad changed the title build: Make the mobile package visibility only to other mobile dirs build: Make the mobile package visible only to other mobile dirs Nov 10, 2022
Copy link
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bonus points if you do an EM version bump as we'll need to add this to the EM build system file

@alyssawilk alyssawilk merged commit 3b8beab into envoyproxy:main Nov 14, 2022
@abeyad abeyad deleted the mobile_visibility branch November 14, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants