Skip to content

Cleanup: Update comment.#23929

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
KBaichoo:minor-fixes
Nov 11, 2022
Merged

Cleanup: Update comment.#23929
phlax merged 1 commit intoenvoyproxy:mainfrom
KBaichoo:minor-fixes

Conversation

@KBaichoo
Copy link
Copy Markdown
Contributor

Signed-off-by: Kevin Baichoo kbaichoo@google.com

Commit Message: Cleanup: Update comment.
Additional Description: In original PR: #15172 we send onLocalReply to all filters, there's no onLocalError
Risk Level: low
Testing:
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
@KBaichoo
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #23929 (comment) was created by @KBaichoo.

see: more, trace.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @KBaichoo

@phlax phlax merged commit 655ff4c into envoyproxy:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants