Skip to content

[backport/1.21] repo: Dev 1.21.6 (+ci fixes)#23852

Merged
phlax merged 4 commits intoenvoyproxy:release/v1.21from
phlax:release-1.21
Nov 8, 2022
Merged

[backport/1.21] repo: Dev 1.21.6 (+ci fixes)#23852
phlax merged 4 commits intoenvoyproxy:release/v1.21from
phlax:release-1.21

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Nov 7, 2022

open branch to dev

backports

Previously /var/run/docker.sock is readable/writable inside docker run because group ID of envoygroup coincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcing envoygroup has host docker group ID.

Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Lizan Zhou lizan@tetrate.io
Signed-off-by: Ryan Northey ryan@synca.io

Commit Message:
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@phlax phlax changed the title ci: use host docker gid for envoybuild (#23803) [backport/1.21] ci: use host docker gid for envoybuild (#23803) Nov 7, 2022
@phlax phlax added this to the 1.21.6 milestone Nov 7, 2022
@phlax phlax changed the title [backport/1.21] ci: use host docker gid for envoybuild (#23803) [backport/1.21] repo: Dev 1.21.6 (+ci fixes) Nov 7, 2022
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 7, 2022

/docs

@repokitteh-read-only
Copy link
Copy Markdown

Docs for this Pull Request will be rendered here:

https://storage.googleapis.com/envoy-pr/23852/docs/index.html

The docs are (re-)rendered each time the CI envoy-presubmit (precheck docs) job completes.

🐱

Caused by: a #23852 (comment) was created by @phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 7, 2022

gh action is failing due to clang versioning - seems like there are some workarounds here https://github.com/circleci/circleci-images/issues/430

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Nov 7, 2022

possibly we can backport a fix - ill check further

@phlax phlax changed the title [backport/1.21] repo: Dev 1.21.6 (+ci fixes) [WIP/backport/1.21] repo: Dev 1.21.6 (+ci fixes) Nov 7, 2022
@phlax phlax marked this pull request as draft November 7, 2022 11:58
phlax and others added 3 commits November 7, 2022 12:43
Signed-off-by: Ryan Northey <ryan@synca.io>
Previously `/var/run/docker.sock` is readable/writable inside docker run because group ID of `envoygroup` coincidentally matches host docker group, while it is no longer true during rolling out new image. Fixing that by forcing `envoygroup` has host docker group ID.

Risk Level: Low
Testing: CI
Docs Changes:
Release Notes:
Platform Specific Features:

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax force-pushed the release-1.21 branch 2 times, most recently from 61d6fb1 to b957bd9 Compare November 8, 2022 13:29
* ocsp: rotate certs of test data

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

* fix format

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>

Signed-off-by: wbpcode <wangbaiping@corp.netease.com>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax changed the title [WIP/backport/1.21] repo: Dev 1.21.6 (+ci fixes) [backport/1.21] repo: Dev 1.21.6 (+ci fixes) Nov 8, 2022
@phlax phlax marked this pull request as ready for review November 8, 2022 14:37
@phlax phlax requested review from ggreenway and lizan as code owners November 8, 2022 14:37
@phlax phlax merged commit 3a43ea7 into envoyproxy:release/v1.21 Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants